Re: Question on -Werror usage in Makefiles...

[Andreas Jaeger <aj at suse dot de>]

Eric Botcazou <ebotcazou@libertysurf.fr> writes:

>> Then add a -Wno-error or -Wno-strict-prototypes to the correct
>> makefile for this file...
>
> Sure, but Solaris is not the only non-Linux OS out there...
>
>> Please try adding
>> unwind-dw2.c-warn = -Wno-error
>> to Makefile.in
>
> Works of course.

Then please send a patch for e.g. adding it to config/sparc/t-sol2.

>> > How can such a patch have been accepted during stage3?
>>
>> To catch the introduction of additional warnings and thereby making
>> GCC better,
>
> Take a look at http://gcc.gnu.org/develop.html:
>
> "Stage 3
> During this period, the only (non-documentation) changes that may be made are 
> changes that fix bugs. New functionality may not be introduced during this 
> period."

Fixing warnings means fixing potential bugs, so this helps.  And we've
never been really strict about this rule but yes, this could be
considered as a not appropriate...

If we figure out that we cannot get some platforms to bootstrap with
this change, then let's revert it.  But let's give it a try, I see the
benefits more than the problems.

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Deutschherrnstr. 15-19, 90429 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature