Re: Question on -Werror usage in Makefiles...

[Andreas Jaeger <aj at suse dot de>]

Andreas Jaeger <aj@suse.de> writes:

> Andreas Jaeger <aj@suse.de> writes:
>
>> Andreas Jaeger <aj@suse.de> writes:
>>
>>> make proto now throws errors.  Is the appended patch the right thing
>>> to do fix the warnings when building SYSCALLS.o ?
>>
>> Digging deeper into this, I see that the following should do the trick
>> - but doesn't:
>> SYSCALLS.c.X-warn = -Wno-error
>>
>> GCC_CFLAGS should include WARN_CFLAGS for this to work.
>>
>> I'm testing now the appended patch.  Ok to commit this version if it
>> passes bootstrap on x86_64-linux-gnu?
>
> My change adds STRICT_WARN for the files which then enables additional
> warnings.  I'm not sure whether we want this :-(
>
> So, I see the following solutions:
> - Reverting Kaveh's patch that I committed
> - Adding some hack so that e.g.  SYSCALLS.c.X-warn = -Wno-error works
> - Using my patch below and adding -Wno-error to GCC_CFLAGS since we
>   get too many warnings otherwise and this helps to cut them down.
> - Using my patch below and white-listening the files that make
>   problems
> - Using my patch below and fixing everything.
>
> I'll work on the fixing the obvious warnings now but I'm sure that I
> cannot fix everything directly...

On x86_64-linux-gnu I get while compiling crtbegin.o:

/usr/src/aj/cvs/gcc/gcc/unwind-dw2-fde.h:37: warning: ISO C90 does not support flexible array members
/usr/src/aj/cvs/gcc/gcc/unwind-dw2-fde.h:53: warning: bit-field 'sorted' type invalid in ISO C
/usr/src/aj/cvs/gcc/gcc/unwind-dw2-fde.h:54: warning: bit-field 'from_array' type invalid in ISO C
/usr/src/aj/cvs/gcc/gcc/unwind-dw2-fde.h:55: warning: bit-field 'mixed_encoding' type invalid in ISO C
/usr/src/aj/cvs/gcc/gcc/unwind-dw2-fde.h:56: warning: bit-field 'encoding' type invalid in ISO C
/usr/src/aj/cvs/gcc/gcc/unwind-dw2-fde.h:59: warning: bit-field 'count' type invalid in ISO C
/usr/src/aj/cvs/gcc/gcc/unwind-dw2-fde.h:139: warning: ISO C90 does not support flexible array members
/usr/src/aj/cvs/gcc/gcc/unwind-dw2-fde.h:147: warning: ISO C90 does not support flexible array members
/usr/src/aj/cvs/gcc/gcc/unwind-dw2-fde.h:157: warning: pointer of type `void *' used in arithmetic
/usr/src/aj/cvs/gcc/gcc/crtstuff.c:209: warning: ISO C forbids empty initializer braces

Unfortunatly a simple:
crtbegin.o = -Wno-error

Does not help at all :-(.  So, white-listening does not seem to
work:-(

Can anybody help me, please?

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Deutschherrnstr. 15-19, 90429 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature