This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Question on -Werror usage in Makefiles...
Andreas Jaeger <aj@suse.de> writes:
> "Zack Weinberg" <zack@codesourcery.com> writes:
>
>> Andreas Jaeger <aj@suse.de> writes:
>>
>>> With your patch I get on x86_64-linux-gnu the following error:
>>> In file included from /usr/src/aj/cvs/gcc/gcc/unwind-dw2-fde-glibc.c:58:
>>> /usr/src/aj/cvs/gcc/gcc/unwind-dw2-fde.c: In function `fde_insert':
>>> /usr/src/aj/cvs/gcc/gcc/unwind-dw2-fde.c:413: warning: assignment discards qualifiers from pointer target type
>>
>> I do not understand why this is happening. I saw that on i386-linux
>> but it went away when I made the array field of struct fde_vector be
>> const.
>
> Your patch did not apply cleanly (patch rejected it as broken) and I
> handedited it - and it seems I didn't do that correctly. There was
> nevertheless one warning missing, I'm appending my current patch that
> works for me.
>
> Ok to commit? I'll bootstrap now on x86_64-linux-gnu with all
> languages to double check...
Assuming your check succeeds, yes, go ahead and check this in. We
will probably need to deal with further breakage but I think it's best
if that is done in follow-up patches.
zw