This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: RFA add case to purge addressof
- From: Roger Sayle <roger at eyesopen dot com>
- To: Eric Christopher <echristo at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 29 Oct 2003 07:12:41 -0700 (MST)
- Subject: Re: PATCH: RFA add case to purge addressof
Hi Eric,
On Tue, 28 Oct 2003, Eric Christopher wrote:
> > The patch itself looks reasonable, but is there any reason why the new
> > "GET_MODE_SIZE (GET_MODE (x)) < GET_MODE_SIZE (GET_MODE (sub))" couldn't
> > be added to the disjuntion in the previous if statement. It looks like
> > you're just duplicating "*loc = gen_rtx_SUBREG (GET_MODE (x), sub, 0);
> > return true;".
>
> No reason at all.
...
>
> > Finally, in stage3, I'd feel happier if we didn't add the new call to
> > "abort()".
>
> OK. I wasn't particularly attached to the abort.
If you do another bootstrap and testsuite run, with these two changes,
and then post the updated patch to gcc-patches, I'll approve it.
Roger
--