Re: [PATCH] [please commit] libffi reorg [take 4]

[Andreas Tobler <toa at pop dot agri dot ch>]

Rainer Orth wrote:

> Paolo Bonzini <paolo.bonzini@polimi.it> writes:
>
>
> >        include/ffitarget.h instead of include/fficonfig.h.  Rename
> >        MIPS_GCC to MIPS_IRIX, drop MIPS_SGI since we are in gcc's tree.
>
>
> I just noticed this part of the change and don't think it is ok: even if
> the master version of libffi is now (or will shortly be) in the GCC tree,
> we shouldn't drop support for vendor compilers.  It is often essential to
> test libffi both with gcc and cc to check if a particular failure is a gcc
> or libffi bug.
>
> Apart from this change, there are certainly other problems when using
> libffi from the GCC tree with vendor compilers (as I discovered when I
> tried testing it with cc on IRIX 6 and Tru64 UNIX).  I'll probably work on
> re-enabling this ability in the future.

I did just the work of applying the patch :)
Your argument seems ok to me. Afaik libffi is also used outside from 
gcc. So it seems reasonable to me to keep support for other compilers if 
possible.
I suggest to go ahead and work out a patch to re enable this support.

and sorry for the possible breakage.

Andreas