This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [m68k] remove obsolete comments from m68k.c


Bernardo Innocenti <bernie@develer.com> writes:

> Gunther Nikl wrote:
>
>>>>>In a previous patch some comments about asm_fprintf() not handling '%' got
>>>>>removed. The attached patch removes some more occurences.
>>>>
>>>>Why?  The comment is actually talking about %. and is still correct.
>>>>Otherwise most of these #ifdef MOTOROLA could be removed.
>>>
>>>The comments are right, but IMHO it's pointless and it makes those
>>>#ifdef/#else/#endif blocks even harder to parse with the eye.
>>>
>>>If we _really_ want to advertise this fact, we could use a single, more
>>>descriptive comment somewhere near the top of m68k.c.
>>   Fine with me.
>
> If it's ok for Andreas, I will commit your patch as obvious.

Yes, it's ok for me.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]