This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: typedef fileline location_t
Per Bothner <per@bothner.com> writes:
> That is one of the issues I wanted feedback on, but I wasn't
> explicit. The patches makes the two typedef names 'fileline'
> and 'location_t' equivalent. That is one too many. My
> suggestion is keeping 'fileline' and removing 'location_t'
> mainly because the work "location" is more ambiguous: It
> could just as easily refer to locations in memory or in a
> register, for example. A 'fileline' is less ambiguous.
The problem with this is you're going to have to change them all again
if you ever add column information. May I suggest 'srcloc_t' or
'struct srcloc' which are unambiguous about what kind of location, but
avoid indicating exactly what is recorded?
zw