This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: 3.4 PATCH: Improve IRIX 6.5 <internal/stdio_core.h> fixing
Rainer Orth wrote:
>
> Bruce Korb writes:
>
> > I'm surprised it works. This expression:
> > > + "s@[ \t]va_list _ap;@__gnuc_va_list _ap;@\n"
> >
> > ought to leave the above line looking like this:
> > > + __SGI_LIBC_NAMESPACE_QUALIFIER__gnuc_va_list _ap;
> >
> > assuming I am not misreading :-}, that isn't exactly right,
> > either. (easy to do, misreading that stuff ...)
> > Ah, I get it, this new expression doesn't function
> > anymore because the first substitution will always catch
> > it first. Please, just delete the expression. Thanks.
>
> Indeed: I've just removed it, rebuilt/reran fixincludes and verified that
> interlal/stdio_core.h is still fixed correctly. Thanks for catching this.
>
> Ok with that change?
Fine by me. - Cheers, Bruce