This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [v3] add -Wcast-qual to WARN_FLAGS
>Question, why do we need -Wno-format? Is there some unfixable wart in
>the code somewhere?
>
>If not, would it not be worthwhile to eliminate whatever warnings
>-Wformat exposes?
You are correct: I've removed it, and since -Wformat is on by -Wall, I
don't need to add it explicitly.
best,
benjamin
2003-09-18 Benjamin Kosnik <bkoz@redhat.com>
PR libstdc++/11504
* acinclude.m4 (GLIBCXX_EXPORT_FLAGS): Add -Wcast-qual to
WARN_FLAGS, remove -Wno-format.
* aclocal.m4: Regenerate.
* configure: Regenerate.
Index: acinclude.m4
===================================================================
RCS file: /cvs/gcc/gcc/libstdc++-v3/acinclude.m4,v
retrieving revision 1.270
diff -c -p -r1.270 acinclude.m4
*** acinclude.m4 11 Sep 2003 03:11:31 -0000 1.270
--- acinclude.m4 18 Sep 2003 14:22:53 -0000
*************** AC_DEFUN(GLIBCXX_EXPORT_FLAGS, [
*** 656,662 ****
OPTIMIZE_CXXFLAGS=
AC_SUBST(OPTIMIZE_CXXFLAGS)
! WARN_FLAGS='-Wall -Wno-format -W -Wwrite-strings'
AC_SUBST(WARN_FLAGS)
])
--- 656,662 ----
OPTIMIZE_CXXFLAGS=
AC_SUBST(OPTIMIZE_CXXFLAGS)
! WARN_FLAGS='-Wall -W -Wwrite-strings -Wcast-qual'
AC_SUBST(WARN_FLAGS)
])