This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH to initialize pretty_printer's line_length
- From: Gabriel Dos Reis <gdr at integrable-solutions dot net>
- To: Jason Merrill <jason at redhat dot com>
- Cc: Per Bothner <per at bothner dot com>, gcc-patches at gcc dot gnu dot org
- Date: 12 Sep 2003 08:03:14 +0200
- Subject: Re: PATCH to initialize pretty_printer's line_length
- Organization: Integrable Solutions
- References: <3F615D4F.8090005@bothner.com><wvlk78ek17x.fsf@prospero.boston.redhat.com>
Jason Merrill <jason@redhat.com> writes:
| On Thu, 11 Sep 2003 22:44:47 -0700, Per Bothner <per@bothner.com> wrote:
|
| > It doesn't appear that the line_length field of
| > a pretty_printer is initialized anywhere. It also
| > appears this is the cause of a problem I observed
| > in that the file+line prefix of an error message
| > wasn't being printed.
| >
| > Ok to check in?
|
| Instead, please change the xmalloc for the buffer to use xcalloc so that
| this won't break the next time someone adds a field.
this seems better indeed. Thanks.
-- Gaby