This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: More Makefile cleanups
On Sat, 2003-08-30 at 03:41, Joseph S. Myers wrote:
> On Fri, 29 Aug 2003, Mark Mitchell wrote:
>
> > ! check-g++: $(TESTSUITEDIR)/site.exp
>
> [...]
>
> > ! check-g++ check-gcc check-g77 check-objc: check-% : $(TESTSUITEDIR)/site.exp
>
> This code does need cleaning up, but not this way. The hardcoded mentions
> of specific languages should leave Makefile.in altogether, moving to the
> Make-lang.in files (probably using the existing hook mechanism, so the
> targets become cp.check etc.). Now, GNU make can hopefully be used to
> eliminate duplication between the Make-lang.in files, for this and other
> commands, but I don't see that merging all the language check rules in
> this way is an improvement, as a simple fix for the bug that these
> language mentions are hardcoded in Makefile.in would just duplicate the
> rules again in the course of moving them to Make-lang.in.
Not at all.
Instead, it would change to:
$(lang_checks): check-% : $(TESTSUITEDIR)/site.exp
...
and, for example, cp/Make-lang.in would do:
lang_checks += check-g++
--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com