This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: More Makefile cleanups
- From: "Joseph S. Myers" <jsm at polyomino dot org dot uk>
- To: Mark Mitchell <mark at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sat, 30 Aug 2003 11:41:21 +0100 (BST)
- Subject: Re: PATCH: More Makefile cleanups
- References: <200308300124.h7U1OU9a025624@doubledemon.codesourcery.com>
On Fri, 29 Aug 2003, Mark Mitchell wrote:
> ! check-g++: $(TESTSUITEDIR)/site.exp
[...]
> ! check-g++ check-gcc check-g77 check-objc: check-% : $(TESTSUITEDIR)/site.exp
This code does need cleaning up, but not this way. The hardcoded mentions
of specific languages should leave Makefile.in altogether, moving to the
Make-lang.in files (probably using the existing hook mechanism, so the
targets become cp.check etc.). Now, GNU make can hopefully be used to
eliminate duplication between the Make-lang.in files, for this and other
commands, but I don't see that merging all the language check rules in
this way is an improvement, as a simple fix for the bug that these
language mentions are hardcoded in Makefile.in would just duplicate the
rules again in the course of moving them to Make-lang.in.
--
Joseph S. Myers
jsm@polyomino.org.uk