Re: [patch] libffi darwin structure implementation (PPC)

[Andreas Tobler <toa at pop dot agri dot ch>]

Andrew Pinski wrote:

> > Comments are welcome.
>
> Only two comments/suggestions.
>
>
> > +      tramp[1] = 0x4800000d;  /*   bl      10 <trampoline_initial+0x10>  */
>
>
> Since this messes up the lr stack which is a speed lose, can you can change it to "bcl 20,31,0x10"?

Like in the darwin-tramp.asm?

> Also change the following so they do not use cats as lvalue GCC extension as we really want to get rid of it:
>
> +      *(void **) &tramp[2] = (void *)ffi_closure_ASM; /* function  */
> +      *(void **) &tramp[3] = (void *)closure;         /* context  */

Ok, have to figure out what you mean exactly. I guess you mean 'casts' ?

> I know that you really did not change any thing around this but it would be nice for these two changes.

Well, I mean it is code which is coming from me, so if I manage it I 
have no problem with at all.
Have to investigate the second change.

Thank you for taking the time and having had a look at.

Andreas