This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] libffi darwin structure implementation (PPC)
- From: Andrew Pinski <pinskia at physics dot uc dot edu>
- To: toa at pop dot agri dot ch (Andreas Tobler)
- Cc: gcc-patches at gcc dot gnu dot org (gcc-patches), geoffk at geoffk dot org (Geoff Keating), dje at watson dot ibm dot com (David Edelsohn), green at redhat dot com (Anthony Green)
- Date: Fri, 29 Aug 2003 15:10:16 -0400 (EDT)
- Subject: Re: [patch] libffi darwin structure implementation (PPC)
> Comments are welcome.
Only two comments/suggestions.
> + tramp[1] = 0x4800000d; /* bl 10 <trampoline_initial+0x10> */
Since this messes up the lr stack which is a speed lose, can you can change it to "bcl 20,31,0x10"?
Also change the following so they do not use cats as lvalue GCC extension as we really want to get rid of it:
+ *(void **) &tramp[2] = (void *)ffi_closure_ASM; /* function */
+ *(void **) &tramp[3] = (void *)closure; /* context */
I know that you really did not change any thing around this but it would be nice for these two changes.
Thanks,
Andrew Pinski