Re: PATCH: Use GNU Makeisms to simplify libgcc build

[Alexandre Oliva <aoliva at redhat dot com>]

On Aug 29, 2003, Richard Henderson <rth@redhat.com> wrote:

> Actually, if we require gnu make, then we don't need mklibgcc.in at all,
> and thus do not need to generate a 400k libgcc.mk and include it.  We
> can use text expansion functions to do the job directly.

I feel uncomfortable with the use of such GNU make features, but I
wouldn't go as far as pre-rejecting the patch.  Let's see it, and
judge it on its own merits.  We've overcome the hurdle of whether we
*may* rely on GNU make features: the SC has already made this
political decision.  Now, whether to use a GNU make feature or not is
a technical decision, and the SC hasn't generally taken part in such
decisions: it defers to maintainers.  If it turns out that the SC
really meant to require the build machinery maintainers to accept GNU
make features, then it's probably time for the SC to invite whoever
championed the use of GNU make into being a maintainer of the build
machinery, since we need someone who actually cares about such
features to maintain them, and my knowledge about the features that
are portable would no longer be useful.

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                 aoliva@{redhat.com, gcc.gnu.org}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist                Professional serial bug killer