This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Unreviewed math builtins patch (3x)


Kaveh R. Ghazi wrote:
Patch for gamma, bessel and error function math builtins http://gcc.gnu.org/ml/gcc-patches/2003-08/msg00398.html

Ah. This adds some of the functions I noticed were missing. The complex arithmetic ones are still missing though.


I have some of the same reservations I have with the last patch. Do we really want to give warnings by default for any program that uses function names like j0 and y0?

You have erf{,f,l} as ATTR_MATHFN_FPROUNDING_ERRNO, but the description doesn't say anything about domain errors.

The man page for gamma discourages use of it. Do we really want to implement it?

No man page for significand, but I found it in the info documentation. Now that I thought to check the docs, I found pow10 and exp10 info.

Otherwise this looks OK.

Patch for math builtins (taking pointer arguments)
http://gcc.gnu.org/ml/gcc-patches/2003-08/msg00449.html

Same reservations.


sin and cos are defined with ATTR_MATHFN_FPROUNDING, but sincos isn't, which doesn't seem right.

Otherwise this looks OK.
--
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]