This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [fixinc patch] Correct 2/3 failing test cases
- From: Bruce Korb <bkorb at veritas dot com>
- To: Nathanael Nerode <neroden at twcny dot rr dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 26 Aug 2003 18:06:55 -0700
- Subject: Re: [fixinc patch] Correct 2/3 failing test cases
- Organization: Home
- References: <20030826234728.GA7761@twcny.rr.com>
Nathanael Nerode wrote:
>
> These are stupid little differences. The difference in string.h
> is a matter of spacing (and the new version corresponds to the source).
> The difference in sys/regset.h involves a tab which (apparently) used
> to get lost and doesn't get lost any more.
>
> OK to commit, Bruce?
Yes.
I've seen white space differences before, too. It seems to be
a sed thing. i.e., it depends upon which one you use. I think
it might be a good idea to use this for the diff. What do you think?
Index: check.tpl
===================================================================
RCS file: /cvs/gcc/gcc/gcc/fixinc/check.tpl,v
retrieving revision 1.19
diff -u -p -r1.19 check.tpl
--- check.tpl 28 May 2003 11:53:34 -0000 1.19
+++ check.tpl 27 Aug 2003 00:52:46 -0000
@@ -130,12 +130,12 @@ do
echo "Newly fixed header: $f" >&2
exitok=false
- elif cmp $f ${TESTBASE}/$f >&2
+ elif ${DIFF:-diff} -qwb $f ${TESTBASE}/$f >/dev/null 2>&1
then
:
else
- ${DIFF:-diff} -c $f ${TESTBASE}/$f >&2 || :
+ ${DIFF:-diff} -cwb $f ${TESTBASE}/$f >&2 || :
exitok=false
fi
done