This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] RTL optimize sqrt on targets without a sqrt insn
- From: "Zack Weinberg" <zack at codesourcery dot com>
- To: Roger Sayle <roger at eyesopen dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 25 Aug 2003 12:26:02 -0700
- Subject: Re: [PATCH] RTL optimize sqrt on targets without a sqrt insn
- References: <Pine.LNX.4.44.0307200651450.1130-100000@www.eyesopen.com>
Roger Sayle <roger@eyesopen.com> writes:
> 2003-07-20 Roger Sayle <roger@eyesopen.com>
>
> * builtins.c (expand_builtin_mathfn): Rearrange so that we only
> return 0 for invalid argument types. Instead drop through to a
> call of expand_call at the bottom of function. If op is SQRT,
> try attaching a SQRT rtx as the REQ_EQUAL note of the libcall.
This is OK. Apologies for the lengthy wait for review.
> [Also I'd really appreciate it if someone could approve Dave Anglin's
> http://gcc.gnu.org/ml/gcc-patches/2003-07/msg00247.html, this both
> fixes a serious bootstrap problem, and documents the current behaviour
> of REG_EQUAL notes in GCC.
...
I'm not going to overrule Geoff on this one, sorry.
zw