This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C++ patch] one more missed mark_used
On Sat, 2003-08-02 at 13:54, Jason Merrill wrote:
> On 02 Aug 2003 13:24:05 -0700, Mark Mitchell <mark@codesourcery.com> wrote:
>
> > This code:
> >
> > + if (type)
> > + {
> > + tree tinfo = get_tinfo_decl (type);
> > + mark_used (tinfo);
> > + }
> >
> > will penalize not-function-at-a-time mode compilation because it will
> > result in generating additional typeinfos, even when the back end
> > optimizes away the handlers.
>
> I had the same concern, but then thought it was OK because DECL_NEEDED_P
> won't be true unless we actually refer to the symobl. Do you disagree?
No, you're correct. I hadn't taken that into account. We'll still call
assemble_external for each tinfo, but I guess that's reasonably
harmless? (And clearly the real fix for that has nothing to with Jan's
stuff; that happens any time we call mark used.)
I withdraw the objection.
Thanks,
--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com