This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH to move in_fnames etc from c-opts.c to opts.c


Zack Weinberg wrote:-

> Per Bothner <per@bothner.com> writes:
> 
> > This moves some of the support for multiple input fiels from c-opts.c
> > to opts.c.  This makes it at least potentially language-indendent.
> > More import to me is that brings the code closer to the compiler
> > server, as I trying to figure out how to update my compile server code
> > to deal with Goeff's and Neil's recent check-ins.  It also is a minor
> > simplification, as it removes a useless lang hook.
> 
> I like this patch in principle.  If Neil also likes it, it is approved
> with one minor fix: You forgot to update the dependency list of
> c-decl.o in the Makefile.

Sure, I have no problem with it.

However, there was a good reason for the langhook which it looks like
Geoff might have broken.  We want CPP to accept an input and output
file on the command line like so:

cpp file.in file.out

(and similarly I guess for gcc -E).  cc1 used to be able to handle
this too, though I don't think cc1 matters too much.

If this has been broken (sorry I can't check just now) then it has to
be fixed.

Neil.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]