This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [v3] c++config cleanups
>> - // Hopefully temporary workaround to autoconf/m4 issue with quoting '@'.
>> - #define _GLIBCXX_AT_AT "@@"
>
>Where does/did this get used? Is it fixed? (I don't remember it going
>in to being with.)
It's used for the symbol renaming bits, but should be moved elsewhere.
When it's necessary to deal, I'm hoping that the original issue (quoting
@) will not longer be present...
>> - // Default to the typically high-speed, pool-based allocator (as
>> - // libstdc++-v2) instead of the malloc-based allocator (libstdc++-v3
>> - // snapshots). See libstdc++-v3/docs/html/17_intro/howto.html for
>> - // details on why you don't want to override this setting. Ensure
>> - // that threads are properly configured on your platform before
>> - // assigning blame to the STL container-memory allocator. After doing
>> - // so, please report any possible issues to libstdc++@gcc.gnu.org .
>> - // Do not define __USE_MALLOC on the command line. Enforce it here:
>> - #ifdef __USE_MALLOC
>> - # error __USE_MALLOC should never be defined. Read the release notes.
>> - #endif
>
>Is this error caught somewhere else? I'm comfortable removing this hook
>if we're fairly certain nobody is still trying to define this themselves.
No, it's not (but it is documented elsewhere). There are tons of macros
that we could warn about. Let's just not warn about any of them...
>> - // The remainder of the prewritten config is mostly automatic; all the
>> - // user hooks are listed above.
>> -
>> // Create a boolean flag to be used to determine if --fast-math is set.
>> #ifdef __FAST_MATH__
>> # define _GLIBCXX_FAST_MATH 1
>> --- 57,62 ----
>> ***************
>> *** 103,106 ****
>> // for something else under certain OSes (see BADNAMES).
>> #define __N(msgid) (msgid)
>>
>> ! // End of prewritten config; the discovered settings follow.
>> --- 70,74 ----
>> // for something else under certain OSes (see BADNAMES).
>> #define __N(msgid) (msgid)
>>
>> ! // The remainder of the prewritten config is mostly automatic; all the
>> ! // user hooks are listed above: the discovered settings follow.
>
>Could I ask you to hold off on this change? _GLIBCXX_FAST_MATH and __N
>are emphatically /not/ user hooks, and shouldn't be described as such.
>If there's a better place to put those macros, I'd like to move them.
>Until then, please leave the "dividing line" comment.
Whoops. If you want to move these back, please feel free.
best,
benjamin