This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Unreviewed Patch [Was: Patch: dbxout.c: Fix symbol-table entry descriptioncomment]


Hi,

    This trivial patch of mine submitted in Nov 2002
went unreviewed at the time:

http://gcc.gnu.org/ml/gcc-patches/2002-11/msg01896.html

Can someone please review and commit it if
it is acceptable?

Thanks.

Ranjit.

--------------------------------- 8< -----------------------------------
Hi,

     While browsing through "gcc/dbxout.c" recently trying
to understand stabs output, I noticed a discrepancy in
the leader comment w.r.t. to what actually was being
done by the dbxout_symbol( ) and dbxout_finish_symbol( )
functions - a stabs symbol table entry has *five*
operands instead of the four indicated by the comment (it
misses out the "description" field).

The following patch proposes to fix this anomaly.

ChangeLog:

2002-11-29  Ranjit Mathew <rmathew@hotmail.com>

     * dbxout.c: Fix stabs symbol table entry description
     comment to include the "description" operand to the
     .stabs assembler pseudo-op.

--------------------------------- 8< -----------------------------------
--- dbxout.c    Fri Nov 29 11:24:28 2002
+++ dbxout.c    Fri Nov 29 11:28:53 2002
@@ -23,8 +23,10 @@
  /* Output dbx-format symbol table data.
     This consists of many symbol table entries, each of them
-   a .stabs assembler pseudo-op with four operands:
+   a .stabs assembler pseudo-op with five operands:
     a "name" which is really a description of one symbol and its type,
     a "code", which is a symbol defined in stab.h whose name starts
with N_,
     an unused operand always 0,
+   a "description", which corresponds to the line number of the
+   declaration of the symbol if using GNU debug extensions,
+   and 0 otherwise,
     and a "value" which is an address or an offset.
     The name is enclosed in doublequote characters.
--------------------------------- 8< -----------------------------------

Sincerely Yours,
Ranjit.

-- 
Ranjit Mathew          Email: rmathew AT hotmail DOT com

Bangalore, INDIA.      Web: http://ranjitmathew.tripod.com/



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]