Re: [PATCH] Fix some Objective-C failures on *-*-darwin* (nextruntime)

[Nicola Pero <nicola at brainstorm dot co dot uk>]

Hi Andrew,

what about telling us a bit more why this patch is required ?

Having some root classes in the testsuite is good, as defining a new root
class is one of the Objective-C features we want to test after all.  It's
not clear why you want everything to inherit from Object.  As far as I
know, if defining a new root class fails, that's a bug to fix - you
shouldn't be modifying the testcase, but fixing the bug in the compiler!

I don't have the Apple Objective-C runtime (which is not free software
btw) so I don't even know what problems you are trying to solve.  Could
you let us know what the errors are ?


> Here is patch which changes some of the Objective-C tests so that they 
> pass on *-*-darwin* which uses by default the NeXT runtime.

By the way, I have never been convinced by the change (applied without
much discussion and ignoring my requests for more explanations) which
prevents the GNU Objective-C runtime from even being compiled on Apple.

I don't like the Apple Objective-C runtime license, and it's not a free
software license, and it seems very unfortunate that the official GNU
compiler does not even install an alternative free software Objective-C
runtime on darwin, given that a very good one is available.


> ChangeLog:
> 	* objc/execute/redefining_self.m: Include objc/Object.h.
>	Have TestClass inherit from Object. Remove isa  from TestClass.
>	* objc/execute/static-1.m: Include objc/Object.h.
>	Have Test inherit from Object. Remove isa from Test.
>	* objc/execute/static-2.m: Likewise
>	* objc/execute/va_method.m: Include objc/Object.h and stdarg.h.
>	Have MathClass inherit from Object. Remove isa from MathClass.
>