This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: clean up assembler feature tests; get rid of acconfig.h
- From: "Zack Weinberg" <zack at codesourcery dot com>
- To: Andrew Pinski <pinskia at physics dot uc dot edu>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sat, 12 Jul 2003 17:07:03 -0700
- Subject: Re: clean up assembler feature tests; get rid of acconfig.h
- References: <471E05DD-B4BA-11D7-A533-000393A6D2F2@physics.uc.edu>
Andrew Pinski <pinskia@physics.uc.edu> writes:
> On Saturday, Jul 12, 2003, at 17:29 US/Eastern, Zack Weinberg wrote:
>> My bad. I knew that one needed to be defined unconditionally and then
>> I thinko-ed and put the AC_DEFINE in the only-if-true block anyway.
>> Please try this patch. You'll need to rerun autoconf, but not
>> autoheader.
>>
>> zw
>>
>> * configure.in: Always define HAVE_AS_GOTOFF_IN_DATA for
>> i?86-*-*.
>
>
> That worked except there was warning when running configure
> (Yes I did use the correct version of autoconf, 2.13).
> On i686-pc-linux-gnu using bash as the shell:
> checking assembler for GOTOFF in data... yes
> /home/gates/pinskia/src/gnu/gcc/src/gcc/configure: line 1: test: =:
> unary operator expected
Bleah. Try this patch instead. The code that sets the cache variable
and the code that reads it disagreed on its name; I didn't see it
because I had the old variable in my old config.cache.
zw
* configure.in: Always define HAVE_AS_GOTOFF_IN_DATA for
i?86-*-*. Use correct name of cache variable.
===================================================================
Index: configure.in
--- configure.in 12 Jul 2003 20:03:14 -0000 1.704
+++ configure.in 12 Jul 2003 23:56:13 -0000
@@ -2237,16 +2237,18 @@ changequote([,])dnl
[AC_DEFINE(HAVE_GAS_FILDS_FISTS, 1,
[Define if your assembler uses the new HImode fild and fist notation.])])
+ # This one is used unconditionally by i386.[ch]; it is to be defined
+ # to 1 if the feature is present, 0 otherwise.
gcc_GAS_CHECK_FEATURE([GOTOFF in data],
gcc_cv_as_ix86_gotoff_in_data, [2,11,0],,
[ .text
.L0:
nop
.data
- .long .L0@GOTOFF],,
- [AC_DEFINE_UNQUOTED(HAVE_AS_GOTOFF_IN_DATA,
- [`if test $gcc_cv_as_gotoff_in_data = yes; then echo 1; else echo 0; fi`],
- [Define true if the assembler supports '.long foo@GOTOFF'.])])
+ .long .L0@GOTOFF])
+ AC_DEFINE_UNQUOTED(HAVE_AS_GOTOFF_IN_DATA,
+ [`if test $gcc_cv_as_ix86_gotoff_in_data = yes; then echo 1; else echo 0; fi`],
+ [Define true if the assembler supports '.long foo@GOTOFF'.])
;;
ia64*-*-*)