This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Allow options.[ch] to be possibly regenerated after reconfigure --enable-languages=xxx


Kelley Cook wrote:-

> >Err...  You're passing down only the pathname to move-if-change, but
> >you can't assume that whatever the Makefile understands as ${SHELL}
> >will be available in opts.sh's environment.  You'll see that SHELL is
> >often set in the environment to something that is not necessarily
> >Bourne-shell compatible.  Users of csh variants would experience
> >problems.  Please pass a single quoted argument, as I suggested, and
> >run that as move-if-change.
> 
> Sorry, I misunderstood.  Is the fourth time the charm?
> 
> If so, could you please install?
> 
> Thanks for the review,

Thanks, I'll apply this now.

Neil.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]