This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: cgraph based inlining heuristics


The patch is ok.  Thanks to both you and Gerald for working
out something reasonable wrt inlining.  I understand this
depends on the revised code size estimation patch, which I'll
look at shortly.

Question:

> +       node->local.local = (!node->needed
> + 		           && DECL_SAVED_TREE (node->decl)
> + 			   && !DECL_COMDAT (node->decl)
> + 		           && !TREE_PUBLIC (node->decl));

Is this supposed to mean local-to-this-file, or the slightly
broader local-to-this-dso from targetm.binds_local_p?

Have you ever seen !TREE_PUBLIC && DECL_COMDAT?  That would
be a bug if so.

Didn't you have a patch to dump unit-at-a-time info to a file
instead of to stderr?  I think I'm definitely in favor of that
patch now.  ;-)  Please update and apply.


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]