This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: 3.4 PATCH: Fix IRIX 6 bootstrap failure


Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> writes:

> mips-sgi-irix6.5 failed to bootstrap on mainline:
>
> /vol/gnu/src/gcc/gcc-dist/gcc/c-lex.c: In function `cb_ident':
> /vol/gnu/src/gcc/gcc-dist/gcc/c-lex.c:187: warning: pointer targets in initialization differ in signedness
>
> This happens because cpp_string.text is const unsigned char *, while p in
> mips.h's ASM_OUTPUT_IDENT (and strlen, assemble_string) expect a const char *. 
>
> The following patch fixes this and allowed bootstrap to finish on
> mips-sgi-irix6.5. 
>
> Ok for mainline?

I'd rather you put the cast in cb_ident, as this is likely to crop up
on other targets as well.  cpplib's taste for unsigned char is
supposed to be isolated to cpplib.

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]