Re: PATCH: Support the new demangler written in C++

[Alexandre Oliva <aoliva at redhat dot com>]

On Jul  8, 2003, "H. J. Lu" <hjl@lucon.org> wrote:

> On Mon, Jul 07, 2003 at 07:04:01PM -0700, H. J. Lu wrote:
>> > 
>> > Assuming this is supposed to go in anyway, please make sure you spell
>> > TARGET correctly (it's TERGET in your patch), and move
>> > ALL_TARGET_LIBIBERTY closer to the other ALL*_LIBIBERTY macros.  Also,
>> > make sure they expand to not only maybe-all*-demangler, but also
>> > maybe-all*-libiberty.  The way it is now, should the demangler
>> > directory not be there, it wouldn't build libiberty at all.
>> 
>> I will fix those.

> Here is the new patch with those changes.

Thanks.  I don't have any technical issues with this patch.  I'd only
like to see a comment added before the ALL*_LIBIBERTY definitions
explaining why everybody should be using these instead of
all*-libiberty, with the exception of libstdc++-v3, even if they don't
care about the demangler.  Namely, it's for parallel make safety.  I
do realize now that the reason libstdc++-v3 can do it is that
demangler depends on it libstdc++, so libiberty will never be updated
by demangler while libstdc++ is building.

However, I won't approve this patch for now, because the decision of
whether to introduce a new build requirement for a complete libiberty,
even one disguised as it is, is something that the maintainer of
libiberty should decide whether to approve and impose on its users.

I'd still prefer to have the demangler in libiberty proper, by
experimenting with the possibility of just configuring libstdc++ for
the target before building libiberty, and demanding full C++ compilers
for build and host, unless a configure flag is given to enable the
broken, but C-only, demangler, that could still be useful at least for
bootstrapping purposes.

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                 aoliva@{redhat.com, gcc.gnu.org}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist                Professional serial bug killer