This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: C++ PATCH: Fix PR 5293 (regression)
- From: Jason Merrill <jason at redhat dot com>
- To: Gabriel Dos Reis <gdr at integrable-solutions dot net>
- Cc: gcc-patches at gcc dot gnu dot org, mark at codesourcery dot com
- Date: Mon, 07 Jul 2003 16:17:41 -0400
- Subject: Re: C++ PATCH: Fix PR 5293 (regression)
- References: <m3el125okd.fsf@uniton.integrable-solutions.net>
FYI, I've been told in the past that substituting pieces of text makes life
difficult for translators.
Also, it seems to me that the interesting case is the one where we are
trying to initialize a non-const reference from an rvalue, either because
we explicitly wrote an rvalue or because we need a conversion which
produces an rvalue. You should test for this with NEED_TEMPORARY_P, not
real_lvalue_p.
For other cases, the old error message is correct; telling people that the
argument is an lvalue doesn't help them to find the problem with their
code.
Jason