This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Re: GCC build failed for native with your patch on 2003-07-05T00:22:37Z.


This is caused by Darwin not having iconv so iconv_t is defined in cpphash.h as int but is
compared to size_t in convert_cset in cppcharset.c on line 217.


There are two ways to fix this, either by changing iconv_t to be the same as size_t or
change the comparison to be of type incov_t.
Doing both is the safest.


ChangeLog:
2003-06-04  Andrew Pinski <pinskia@physics.uc.edu>

	* cpphash.h (iconv_t): Change to size_t.
	* cppcharset.c (convert_cset): Compare the result
	of iconv to -1 of type incov_t.

Patch:

Attachment: temp.fixiconv.diff
Description: Binary data




Thanks, Andrew Pinski


On Friday, Jul 4, 2003, at 20:45 US/Eastern, GCC regression checker wrote:


With your recent patch, GCC does not compile on:
 native
Attached is build output for those targets.

The last time the regression tests were run, GCC did not compile either,
so the problem might not be caused by your patch.


For more information, see http://gcc.gnu.org/regtest/.
<ChangeLog.diff><native-log.txt>--
Geoffrey Keating <geoffk@apple.com>
(via an automated GCC regression-testing script.)

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]