This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[patch] clarification: static function name change, removal of comments


Hi,

Included in this mail is a patch which changes the name of the function
"munge" to "munged_copy", and removes the comment /*  Also makes permanent copy*/
from every usage of it.

Martin Schaffner

2003-07-04 Martin Schaffner <schaffner at gmx.li>

    * mkdeps.c: Change name of static function "munge" to "munged_copy",
remove comment at every usage of "munge"

Index: mkdeps.c
===================================================================
RCS file: /cvsroot/gcc/gcc/gcc/mkdeps.c,v
retrieving revision 1.18
diff -c -3 -p -r1.18 mkdeps.c
*** mkdeps.c	16 Jun 2003 21:41:05 -0000	1.18
--- mkdeps.c	4 Jul 2003 19:07:31 -0000
*************** struct deps
*** 39,55 ****
    unsigned int deps_size;
  };
  
! static const char *munge	PARAMS ((const char *));
  
  /* Given a filename, quote characters in that filename which are
     significant to Make.  Note that it's not possible to quote all such
     characters - e.g. \n, %, *, ?, [, \ (in some contexts), and ~ are
     not properly handled.  It isn't possible to get this right in any
     current version of Make.  (??? Still true?  Old comment referred to
!    3.76.1.)  */
     
  static const char *
! munge (filename)
       const char *filename;
  {
    int len;
--- 39,56 ----
    unsigned int deps_size;
  };
  
! static const char *munged_copy	PARAMS ((const char *));
  
  /* Given a filename, quote characters in that filename which are
     significant to Make.  Note that it's not possible to quote all such
     characters - e.g. \n, %, *, ?, [, \ (in some contexts), and ~ are
     not properly handled.  It isn't possible to get this right in any
     current version of Make.  (??? Still true?  Old comment referred to
!    3.76.1.)  The returned string is malloced, it is the caller's
!    responsability to free it.  */
     
  static const char *
! munged_copy (filename)
       const char *filename;
  {
    int len;
*************** deps_add_target (d, t, quote)
*** 167,173 ****
      }
  
    if (quote)
!     t = munge (t);  /* Also makes permanent copy.  */
    else
      t = xstrdup (t);
  
--- 168,174 ----
      }
  
    if (quote)
!     t = munged_copy (t);
    else
      t = xstrdup (t);
  
*************** deps_add_dep (d, t)
*** 213,219 ****
       struct deps *d;
       const char *t;
  {
!   t = munge (t);  /* Also makes permanent copy.  */
  
    if (d->ndeps == d->deps_size)
      {
--- 214,220 ----
       struct deps *d;
       const char *t;
  {
!   t = munged_copy (t);
  
    if (d->ndeps == d->deps_size)
      {

-- 
+++ GMX - Mail, Messaging & more  http://www.gmx.net +++

Jetzt ein- oder umsteigen und USB-Speicheruhr als Prämie sichern!


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]