This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [tree-ssa] PATCH: Java gimplifier


On Sat, 21 Jun 2003 16:26:05 -0400 (EDT), Jeff Sturm <jsturm@one-point.com> wrote:

> On Sat, 21 Jun 2003, Jason Merrill wrote:

>> You shouldn't run the inliner or other tree-ssa optimizers if
>> flag_disable_gimple.
>
> Here I followed the example set by c/c++, and
> keep_function_tree_in_gimple_form returns 0 if flag_disable_gimple.

Ah, OK.

> Is it never safe to call optimize_inline_calls then, either?  I was
> confused a little by the comment in tree-inline.c:
>
> /* I'm not real happy about this, but we need to handle gimple and
>    non-gimple trees.  */

The inliner handles GENERIC, not just GIMPLE, but it doesn't handle
Java-specific (or C-specific) trees.  For instance, it wouldn't know what
to do with a Java block expr.

> Is the following OK, once it passes regression testing?

Yes, thanks.  Oh, and it occurs to me that you should switch over from
old-tree-inline.o to tree-inline.o; now that the Java front end doesn't
need it, old-tree-inline.o can go away.

Jason


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]