This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [tree-ssa] More prep work for CFG EH cleanups
- From: law at redhat dot com
- To: Richard Henderson <rth at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 20 Jun 2003 11:18:26 -0600
- Subject: Re: [tree-ssa] More prep work for CFG EH cleanups
- Reply-to: law at redhat dot com
In message <20030620170529.GB7571@redhat.com>, Richard Henderson writes:
>On Thu, Jun 19, 2003 at 11:57:24PM -0600, law@redhat.com wrote:
>> + FIXME. What to do about cases where the LHS can throw? */
>
>Then nothing to be done, so long as the RHS has no side effects.
OK.
>> + if (flag_exceptions
>> + && ! (DECL_P (*to_p) && DECL_ARTIFICIAL (*to_p))
>> + && ((TREE_CODE (*from_p) == CALL_EXPR
>> + && ! (call_expr_flags (*from_p) & ECF_NOTHROW))
>> + || (flag_non_call_exceptions && could_trap_p (*from_p))))
>
>I strongly recommend pulling this condition out to a function.
It turns out it's not that particularly interesting to do. There's
nowhere else that can use it. What really needs to happen is could_trap_p
needs to be rewritten to make it take an arbitrary gimple expression
and indicate if it could trap.
Jeff