This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Clean-up math builtin argument stabilization
- From: Richard Henderson <rth at redhat dot com>
- To: Roger Sayle <roger at eyesopen dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 18 Jun 2003 16:55:08 -0700
- Subject: Re: [PATCH] Clean-up math builtin argument stabilization
- References: <Pine.LNX.4.44.0306181307070.20380-100000@www.eyesopen.com>
On Wed, Jun 18, 2003 at 01:46:46PM -0600, Roger Sayle wrote:
> The third improvement is to move
> the expansion of the arguments inside the start_sequence(), so if
> we can't expand the intrinsic also avoid emitting the RTL to evaluate
> it's arguments.
This makes the use of SAVE_EXPR invalid, since you threw away its
computation. You can't do this without the somewhat extreme
measures taken in calls.c:fix_unsafe_tree.
Everything else looks ok.
r~