This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR target/10775


On Mon, Jun 09, 2003 at 06:11:13PM +0900, Kazuhiro Inaoka wrote:
> It seems that m32r's epilogue generation code is ignore return
> pattern from the first.
> It uses only TARGET_ASM_FUNCTION_EPILOGUE (m32r_output_function_epilogue).

Hmm.  Didn't notice that, sorry.  I guess the existing "return" 
pattern is a remenant of some older frameless code optimization;
it mislead me to assume the wrong thing.

> Is it a problem of how to generate the epilogue code?

Well, generating epilogues via TARGET_ASM_FUNCTION_EPILOGUE is deprecated,
so it'd be nice to get it changed to build epilogues as rtl at some point.
But it would surely be wrong to make this limited bug fix dependent on that
much larger change.

So your last patch, without the "return_internal" pattern, is ok.  

I'm sorry if I havn't been paying attention: have the assignments
been taken care of with Renesas?


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]