This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [avr] Patch for -mint8 option -- unreviewed patch
- From: Jim Wilson <wilson at tuliptree dot org>
- To: "Svein E. Seldal" <Svein dot Seldal at solidas dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, denisc at overta dot ru, marekm at linux dot org dot pl
- Date: Wed, 04 Jun 2003 11:13:20 -0700
- Subject: Re: [avr] Patch for -mint8 option -- unreviewed patch
- References: <3DE1D77D.3050903@solidas.com> <3EBCDB0B.7070303@solidas.com>
Using 32-bit long long with an 8-bit target is sensible, and is already
done for some other 8-bit targets. So the concept is OK.
You are defining __AVR_INT8__ in two places, which seems redundant. You
only need it in one place. The correct place would be the first one in
TARGET_CPU_CPP_BUILTINS.
The ChangeLog entry isn't correct. You need to list every macro
modified, and briefly describe the change. You haven't done this. So
it should look something like this
* config/avr/avr.h (TARGET_CPU_CPP_BUILTINS): Define __AVR_INT8__
(LONG_LONG_TYPE_SIZE): Check INT_TYPE_SIZE.
The patch is OK with these changes.
The avr has two listed maintainers, so I included them in the cc's in
case they want to comment.
I was going to suggest that a doc change was missing, but then I noticed
that the -mint8 option isn't documented. Perhaps you could add the
missing documentation?
Jim