This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Recent change to mips_output_move
Eric Christopher <echristo@redhat.com> writes:
> On Mon, 2003-06-02 at 12:00, Richard Sandiford wrote:
> > Eric, your last commit had the following (unannounced ;) change to
> > mips_output_move. Was this just something you trying out and
> > committed accidentally? Or was it a deliberate change?
> > (And if it was deliberate, why was it needed? ;)
>
> Dammit. It was part of something I was testing to complete removing
> macro instructions.
Ah, OK.
I personally find "move", "li" and "dli" more readable than things like
"or $4,$5,$0" and "addi $4,$0,0x1000". Any chance of keeping them the
way they are? After all, "move" always expands to a single insn, and we
already restrict ourselves to single-insn "li"s and "dli"s.
> > It breaks mips16 builds, so I'd like to revert it if that's OK...
>
> Yeah, I'd noticed this too - which is why I wasn't planning on
> committing it yet ;)
>
> Please do.
Done, thanks.
Richard