This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA: fix gcc.dg/torture/builtin-noret-2.c for sh-elf
Zack Weinberg wrote:
> You should also remove all definitions of HANDLE_PRAGMA_WEAK from the
> target headers.
There is no such definition in the target headers. The closest thing I
have found is in config/openbsd.h:
/* bug work around: we don't want to support #pragma weak, but the current
code layout needs HANDLE_PRAGMA_WEAK asserted for __attribute((weak)) to
work. On the other hand, we don't define HANDLE_PRAGMA_WEAK directly,
as this depends on a few other details as well... */
#define HANDLE_SYSV_PRAGMA 1
But then, the comment must have been incorrect before, as you stated before:
> #pragma weak is not recognized on all targets where weak symbols are
> meaningful.
So I suspect the HANDLE_SYSV_PRAGMA stayed in there because of oversight
or because people have started to depend on the SYSV pragmas being available.
It's propably to late to remove it now, at most you could deprecate it, but
that would require new code to handle th deprecation warnings.
--
--------------------------
SuperH (UK) Ltd.
2410 Aztec West / Almondsbury / BRISTOL / BS32 4QX
T:+44 1454 465658