This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: binutils without a date is not handled properly without GNU sed
- From: Jakub Jelinek <jakub at redhat dot com>
- To: rittle at labs dot mot dot com
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 15 May 2003 02:17:38 -0400
- Subject: Re: PATCH: binutils without a date is not handled properly without GNU sed
- References: <200305150608.h4F68GTV090658@latour.rsch.comm.mot.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, May 15, 2003 at 01:08:16AM -0500, Loren James Rittle wrote:
> $(ld_vers) is later parsed with expr in a manner that tolerates extra
> dotted numbers after the patch level. I.e. the above final proposal
> would handle the various mutant binutils which add a 4th and 5th
> number to the dotted version number...
>
> Permission to apply to mainline?
Certainly not, this breaks the test.
There were binutils 2.12.90.0.xx releases which did not have proper
hidden support.
If your sed cannot handle \|, then you might try to split setting ld_vers
into all the alternatives (ie. ld_vers=first_alternative;
test -z "$ld_vers" && ld_vers=second_alternative, etc.).
> * configure.in (ld_vers): Simplify sed regexp for portability.
> * configure: Regenerated.
>
> Index: gcc/configure.in
> ===================================================================
> RCS file: /cvs/gcc/gcc/gcc/configure.in,v
> retrieving revision 1.668
> diff -r1.668 configure.in
> 1850c1850
> < ld_vers=`echo $ld_ver | sed -n 's,^.*[ ]\([0-9][0-9]*\.[0-9][0-9]*\(\|\.[0-9][0-9]*\(\|\.[0-9][0-9]*\)\)\)\([ ].*\|\)$,\1,p'`
> ---
> > ld_vers=`echo $ld_ver | sed -n 's,^.*[ ]\([0-9][0-9]*\.[0-9][0-9.]*[0-9]\).*$,\1,p'`
Jakub