This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Patch to use -Werror on ${cpu}.o
- From: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- To: gcc-patches at gcc dot gnu dot org
- Date: Sun, 11 May 2003 19:36:14 -0400 (EDT)
- Subject: Patch to use -Werror on ${cpu}.o
Now that we're requiring ISO C (i.e. not using -Wtraditional) it
should be easier to use -Werror in more places. So I'd like to start
by using -Werror on ${cpu}.o.
To test this, I cross-compiled ${cpu}.o (from host sparc-solaris2.7)
for all of the primary and secondary platforms in the 3.3 criteria
list to check for warnings.
alpha-unknown-linux-gnu
armv4l-unknown-linux-gnu
hppa2.0w-hp-hpux11.00
i386-unknown-freebsd4.5
i686-pc-cygwin
i686-pc-linux-gnu
mips-sgi-irix6.5
powerpc-apple-darwin6.3
powerpc-ibm-aix4.3.3.0
powerpc-linux-gnu
sparc-sun-solaris2.7
sparc-unknown-linux-gnu
x86_64-suse-linux-gnu
Ironically, the one platfrom that had a problem is sparc. So this
patch relies on a previous warning fix I just posted here:
http://gcc.gnu.org/ml/gcc-patches/2003-05/msg00972.html
Other than that there were no problems. I'm sure some of the less
widely used platforms may have a nit or two, but I'm hoping it's
considered fair that by personally checking and fixing the primary and
secondary platforms that the rest are up to other individuals. Though
I'll certainly continue to do a few more as time permits and help with
anyone who has questions about warnings they are trying to fix. And
in a pinch, we still have --disable-werror for someone who is stuck.
Ok for mainline?
Thanks,
--Kaveh
2003-05-11 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
* Makefile.in (out_object_file): Don't set -Wno-error for ${cpu}.o.
diff -rup orig/egcc-CVS20030508/gcc/Makefile.in egcc-CVS20030508/gcc/Makefile.in
--- orig/egcc-CVS20030508/gcc/Makefile.in 2003-05-05 21:01:56.000000000 -0400
+++ egcc-CVS20030508/gcc/Makefile.in 2003-05-09 17:45:52.971444000 -0400
@@ -161,7 +161,6 @@ GCC_WARN_CFLAGS = $(LOOSE_WARN) $($(@D)-
varasm.o-warn = -Wno-error
gcc.o-warn = -Wno-error
insn-conditions.o-warn = -Wno-error
-@out_object_file@-warn = -Wno-error
# Bison-1.75 output often yields (harmless) -Wtraditional warnings
gengtype-yacc.o-warn = -Wno-error
c-parse.o-warn = -Wno-error