Re: Configure option and program transform name

[Michael Eager <eager at mvista dot com>]

DJ Delorie wrote:
> 
> > This patch fixes a problem with parsing configure options when
> > there is a special character in the option.  When you have an option
> > like --program-transform-name=s,^,prefix-, baseargs is built up with
> > quotes around the argument.  Unfortunately, the sed script which is
> > supposed to strip out selected options also eliminates any option
> > which starts with a quote.
> 
> This part is OK.  If you can, please make sure this change is
> committed to both gcc and src, since they're in sync.

I'll produce a patch for src.

> > This also sets program-transform-cross-name to use the same sed
> > script as program-transform-name.
> 
> I don't think this is the right thing to do.
> 
> program-transform-cross-name is used to find the cross-assembler et
> al, and the right way to override those is to set them in the
> environment (i.e. AR_FOR_TARGET=foo-ar).  It is a completely different
> purpose than program-transform-name.  I think the only way we can get
> away with your change is if we also supported overriding
> program_transform_cross_name from the toplevel configure.  There's
> also some interaction with the toplevel configure.in looking for
> target tools.
> 
> But, if you think it's the right thing to do, I'd at least expect an
> enlightened rationale and suitable docs changes.

I think that program-prefix is a bit of a muddle and confusing, with
multiple uses and interactions, but that's beside the point.  Perhaps
it's gotten me muddled and confused.

program_transform_cross_name is also used to generate GCC_CROSS_NAME, 
et al.  GCC_INSTALL_NAME is generated from program_transform_name.
Since you can set program_transform_name from configure, you can 
set the name for a native compiler, but not set the name for a cross.

Another solution would be to use program_transform_name for both native 
and cross compiler names.


> > 2003-05-09  Michael Eager  <eager@mvista.com>
> >
> >       * configure.in: correct sed script
> >       * configure: rebuild
> >       * gcc/Makefile.in: make program-transform-cross-name same
> >          as program-transform-name
> 
> ChangeLog entries should be complete sentences, meaning they should at
> least start with a capital letter and end with a period.  Continuation
> lines should be indented with just a tab, not a tab plus additional
> spaces.  GCC has its own ChangeLog, so the last entry would just say
> "Makefile.in" but would be separate, and go in gcc/ChangeLog.

OK.

> Also, since these two changes are unrelated, they probably should have
> been submitted separately.

Yes, will resubmit two patches.

--
Michael Eager     eager@mvista.com	408-328-8426	
MontaVista Software, Inc. 1237 E. Arques Ave., Sunnyvale, CA  94085