This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: function parms in regs, patch 1 of 3


I looked through this patch, and didn't see any problems. It looks pretty straight
forward. I am willing to approve it if Richard doesn't object.


I have the same concerns as Richard though. The function calling code is complex and fragile. Problems here can result in silent ABI changes that are difficult to detect, particularly since we have no established testsuite for ABI compatibility. You should be prepared to revert the patch if problems arise.

Jim



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]