This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Remove definition of ASM_OUTPUT_ALIGNED_COMMON from arm/elf.h


Hi Guys,

  I am applying the patch below to remove the definition
  ASM_OUTPUT_ALIGNED_COMMON from gcc/config/arm/elf.h.  This definition
  is broken, since it passes the bit-alignment on to the assembler's
  .comm directive, but the ELF version of .comm takes a *byte*
  alignment.  There is no need to fix the definition, since
  gcc/config/elfos.h provides a perfectly adequate version.

Cheers
        Nick

2003-04-28  Nick Clifton  <nickc at redhat dot com>

	* config/arm/elf.h (ASM_OUTPUT_ALIGNED_COMMON): Remove definition.

Index: gcc/config/arm/elf.h
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/arm/elf.h,v
retrieving revision 1.42
diff -c -3 -p -w -r1.42 elf.h
*** gcc/config/arm/elf.h	9 Apr 2003 15:14:23 -0000	1.42
--- gcc/config/arm/elf.h	28 Apr 2003 08:11:46 -0000
***************
*** 132,146 ****
  #undef  TARGET_ASM_NAMED_SECTION
  #define TARGET_ASM_NAMED_SECTION  arm_elf_asm_named_section
  
- #undef  ASM_OUTPUT_ALIGNED_COMMON
- #define ASM_OUTPUT_ALIGNED_COMMON(STREAM, NAME, SIZE, ALIGN)	\
-   do								\
-     {								\
-       fprintf (STREAM, "\t.comm\t");				\
-       assemble_name (STREAM, NAME);				\
-       fprintf (STREAM, ", %d, %d\n", SIZE, ALIGN);		\
-     }								\
-   while (0)
  
  /* For PIC code we need to explicitly specify (PLT) and (GOT) relocs.  */
  #define NEED_PLT_RELOC	flag_pic
--- 132,137 ----


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]