This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Approval: can I commit this please?
- From: Geoff Keating <geoffk at geoffk dot org>
- To: "Kean Johnston" <jkj at sco dot com>
- Cc: <gcc-patches at gcc dot gnu dot org>
- Date: 19 Apr 2003 19:29:32 -0700
- Subject: Re: Approval: can I commit this please?
- References: <00e001c306c6$679f24c0$03419384@shrike>
"Kean Johnston" <jkj at sco dot com> writes:
> The first patch is to configure.in. It detects the GNU
> linker, and only used ld -shared if the GNU linker is
> being used. It used -G else. It also adds /usr/ccs/bin/elf
> to the list of search directories looking for tools, and it
> corrects a test for RO/RW section mixing. The second patch
> is to tlink.c, it adds missing = signs to the putenv calls.
> Someone previously wondered why the arguments to putenv are
> xstrdup'ed in the first place, and I can only assume that
> it helps eliminate warnings, as some systems declare putenv
> to take a char * instead of a const char *.
>
> If someone can give me the nod I'll commit these two changes,
> it's the last of the stuff required to get the SCO port working.
Are you sure this won't break all the ports that aren't SCO and don't
use GNU ld?
The patch also needs a ChangeLog.
--
- Geoffrey Keating <geoffk at geoffk dot org>