This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: Do not call uses_template_parms() unless necessary
- From: Ziemowit Laski <zlaski at apple dot com>
- To: Mark Mitchell <mark at codesourcery dot com>
- Cc: Geoffrey Keating <geoffk at apple dot com>, gcc-patches at gcc dot gnu dot org
- Date: Tue, 15 Apr 2003 11:50:53 -0700
- Subject: Re: PATCH: Do not call uses_template_parms() unless necessary
On Tuesday, Apr 15, 2003, at 11:24 US/Pacific, Mark Mitchell wrote:
Apparently, this is the only place in the cp frontend where this
function might be called with a NULL value. (I'm not too worried
about
anyone suddenly noticing the test is redundant, it took me several
minutes to trace the code flow to be sure that in fact the patch was
safe.)
Well, then, a comment is required at the absolute minimum.
Would one of you please add one that explains what is going on?
Sure, though I'm not sure what it should say that
index_type && uses_template_parms (index_type)
does not say already. :-) Please advise.
--Zem
--------------------------------------------------------------
Ziemowit Laski 1 Infinite Loop, MS 301-2K
Mac OS X Compiler Group Cupertino, CA USA 95014-2083
Apple Computer, Inc. +1.408.974.6229 Fax .5477