This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: GC issues in cc1plus
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Gabriel Dos Reis <gdr at integrable-solutions dot net>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: 31 Mar 2003 11:07:43 -0800
- Subject: Re: GC issues in cc1plus
- References: <m3r88oi2gy.fsf@dromion.integrable-solutions.net>
On Sun, 2003-03-30 at 20:28, Gabriel Dos Reis wrote:
>
> Hi,
> My previous patch ("Unify name lokkup 1/n") seems to have exposed a
> latent GC issue in cc1plus.
This patch is OK, but only if you blow away all of free_bindings.
There's no point in leaving half of the free_bindings list around and
not the other half; that's how we get cruft.
Since the free_bindings optimization is probably a good one, you should
figure out what's gone wrong there. I'm approving the patch only
because we need to get back to bootstrapping; I'm expecting you to track
down the root problem.
(This also shows that your "obvious" patch had non-trivial effects.)
Thanks,
--
Mark Mitchell
CodeSourcery, LLC
mark at codesourcery dot com