This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: review process (was: C++ PATCH: Unify name lookup 2/n)
On Mon, Mar 31, 2003 at 02:14:20PM +1000, Fergus Henderson wrote:
>
> Here are some possible suggestions (I'm just brain-storming here):
Understood and agreed.
> - define a new category of "self-approve" developers?
> These developers would be permitted to approve their own patches
> in particular areas. This could be qualified further, e.g. by
> requiring that the patch be reviewed by at least one
> other person (though the other person need not be
> an official maintainer), and/or that the patch not be
> committed until a week after it had been posted to gcc-patches.
What would this offer us that the existing categories (delimited in the
MAINTAINERS file) do not already offer? Frex, I can self-approve my own
patches to libstdc++. If I feel they are risky, I ask for review by other
maintainers and state that I'll hold off for a few days until someone else
looks the risky patch over. But I cannot self-approve to areas outside
of libstdc++ (barring the usual exceptions). This seems to be equivlent
to your paragraph's points. Am I missing something?
Phil
--
If ye love wealth greater than liberty, the tranquility of servitude greater
than the animating contest for freedom, go home and leave us in peace. We seek
not your counsel, nor your arms. Crouch down and lick the hand that feeds you;
and may posterity forget that ye were our countrymen. - Samuel Adams