This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch to revert varasm.c change, fix PRs 10100 & 10053
- From: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- To: geoffk at geoffk dot org
- Cc: Franz dot Sirl-kernel at lauterbach dot com, gcc-patches at gcc dot gnu dot org, jason at redhat dot com, mark at codesourcery dot com
- Date: Sun, 30 Mar 2003 12:44:01 -0500 (EST)
- Subject: Re: Patch to revert varasm.c change, fix PRs 10100 & 10053
- References: <200303300608.BAA04952@caip.rutgers.edu> <jmbrztjndw.fsf@desire.geoffk.org>
> From: Geoff Keating <geoffk at geoffk dot org>
>
> "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu> writes:
>
> > It's been three weeks since this patch:
> > http://gcc.gnu.org/ml/gcc-patches/2003-03/msg00720.html
> >
> > broke bootstrap on mainline for mips-irix6 and alpha-osf4, and
> > possibly elsewhere. (See PRs 10100 & 10053.) Ok to revert?
>
> I think it would be better to at least try to fix the bug instead,
> especially since it looks like it applies to Linux ports too but doesn't
> produce symptoms in a bootstrap.
If the problematic patch exposes a separate problem, I agree it's good
to fix that. But let's be fair to people impacted by this. After all,
I submitted a PR on March 15 and copied our C++ experts on it back
then. So ample notice has been given.
A fair course seems to be to start the patch reversion 48-hour clock
right now. That should give someone time enough to take a look and if
no solution is forthcoming we revert until it can be fixed properly.
Agreed?
--Kaveh
--
Kaveh R. Ghazi ghazi at caip dot rutgers dot edu