This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch to revert varasm.c change, fix PRs 10100 & 10053
- From: Geoff Keating <geoffk at geoffk dot org>
- To: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Cc: Franz dot Sirl-kernel at lauterbach dot com, gcc-patches at gcc dot gnu dot org
- Date: 29 Mar 2003 23:59:23 -0800
- Subject: Re: Patch to revert varasm.c change, fix PRs 10100 & 10053
- References: <200303300608.BAA04952@caip.rutgers.edu>
"Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu> writes:
> It's been three weeks since this patch:
> http://gcc.gnu.org/ml/gcc-patches/2003-03/msg00720.html
>
> broke bootstrap on mainline for mips-irix6 and alpha-osf4, and
> possibly elsewhere. (See PRs 10100 & 10053.) Ok to revert?
I think it would be better to at least try to fix the bug instead,
especially since it looks like it applies to Linux ports too but doesn't
produce symptoms in a bootstrap. The error is correctly reporting
that the 'weak' attribute will not take effect because it's too late
to change the linkage at this point in the compilation. Presumably,
the C++ frontend is calling comdat_linkage or maybe_make_one_only
after the decl has already been written.
--
- Geoffrey Keating <geoffk at geoffk dot org>