This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 3.4] Warn for always-false bitwise ands
- From: Neil Booth <neil at daikokuya dot co dot uk>
- To: John Levon <levon at movementarian dot org>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 21 Mar 2003 06:39:25 +0000
- Subject: Re: [PATCH 3.4] Warn for always-false bitwise ands
- References: <20030321014040.GA76910@compsoc.man.ac.uk>
John Levon wrote:-
> warn_boolean_bitwise_and.
>
> * c-common.h (boolean_value_p): New. Declare
> warn_boolean_bitwise_and.
>
> * c-opts.c (COMMAND_LINE_OPTIONS): Add
> -Wboolean-bitwise-and.
> (c_common_decode_option): Add to -Wall.
> [OPT_Wboolean_bitwise_and]: Handle.
I just want to question whether having YAO is a good idea.
Why not have the controlling variable set by -Wall like you do?
If the need comes in the future to really have a separate option,
it's trivial to add one.
Neil.